Converts scala functions Span.timestamp, duration to vals #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, Span.timestamp and duration were always derived lazily from annotations. This decouples that logic by converting the scala methods to vals and populating them with `ApplyTimestampAndDuration`. This serves us in at least two ways. First, the implicit association between annotations and timestamp or duration was tested in various components. Making these explicit centralizes the responsibility, and lowers the test burden on other components. Also, we want to formalize these fields in persisted models in support of duration queries and local spans (#807). Organizing logic ahead of this work makes the change to persistence simpler.
7370b8d to
651ecb6
Compare
codefromthecrypt
pushed a commit
that referenced
this pull request
Nov 6, 2015
Converts scala functions Span.timestamp, duration to vals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, Span.timestamp and duration were always derived
lazily from annotations. This decouples that logic by converting the
scala methods to vals and populating them with
ApplyTimestampAndDuration.This serves us in at least two ways. First, the implicit association
between annotations and timestamp or duration was tested in various
components. Making these explicit centralizes the responsibility, and
lowers the test burden on other components. Also, we want to formalize
these fields in persisted models in support of duration queries and
local spans (#807). Organizing logic ahead of this work makes the change
to persistence simpler.