Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settles on a single timestamp for Span #814

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Conversation

codefromthecrypt
Copy link
Member

This moves existing code around the notion of Span.timestamp,
Span.duration discussed in #807.

The impact from a user POV is minimal. endTs, used by the query and UI
formerly looked for the last timestamp in a trace. What this meant is
that if someone clicked search, waited, then clicked search again with
the same endTs, an in-flight trace may "disappear" if it has new
activity. Since endTs is now based on a stable point (the start), a
trace wouldn't disappear anymore. This impact is so subtle that it is
barely worth discussing.

The primary motivation for this change is to simplify the commodity task
of timestamping and duration stamping spans. This is discussed #807, and
directly supports a new minimal design of local spans (#808).

This moves existing code around the notion of Span.timestamp,
Span.duration discussed in #807.

The impact from a user POV is minimal. `endTs`, used by the query and UI
formerly looked for the last timestamp in a trace. What this meant is
that if someone clicked search, waited, then clicked search again with
the same `endTs`, an in-flight trace may "disappear" if it has new
activity. Since `endTs` is now based on a stable point (the start), a
trace wouldn't disappear anymore. This impact is so subtle that it is
barely worth discussing.

The primary motivation for this change is to simplify the commodity task
of timestamping and duration stamping spans. This is discussed #807, and
directly supports a new minimal design of local spans (#808).
@codefromthecrypt
Copy link
Member Author

NOTE: there's zero DDL change needed to support this. However, the interpretation of data is different.

codefromthecrypt pushed a commit that referenced this pull request Nov 4, 2015
Settles on a single timestamp for Span
@codefromthecrypt codefromthecrypt merged commit 17b739d into master Nov 4, 2015
@codefromthecrypt codefromthecrypt deleted the span-timestamp branch November 4, 2015 18:24
@codefromthecrypt codefromthecrypt added the model Modeling of traces label Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Modeling of traces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant