Settles on a single timestamp for Span #814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves existing code around the notion of Span.timestamp,
Span.duration discussed in #807.
The impact from a user POV is minimal.
endTs
, used by the query and UIformerly looked for the last timestamp in a trace. What this meant is
that if someone clicked search, waited, then clicked search again with
the same
endTs
, an in-flight trace may "disappear" if it has newactivity. Since
endTs
is now based on a stable point (the start), atrace wouldn't disappear anymore. This impact is so subtle that it is
barely worth discussing.
The primary motivation for this change is to simplify the commodity task
of timestamping and duration stamping spans. This is discussed #807, and
directly supports a new minimal design of local spans (#808).