Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServerIntegratedBenchmark #3748

Merged

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Mar 5, 2024

Fixes #3646

I found some issues

  • log backend is log4j, not simple logger so lack of file prevented any logging to debug. I figured replacing the config is better than tracking out the log4j transitive
  • The netty version override didn't seem to be kicking in. Sorry, I'm not generally experienced with Maven and also rusty in Java so just redefining is the only approach I could find
  • Something about the healthcheck change doesn't seem to interact well with testcontainers. Doing a direct ping without involving curl instead seems fine to me

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. thanks for taking the time on this!

@codefromthecrypt codefromthecrypt merged commit 53a735d into openzipkin:master Mar 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServerIntegratedBenchmark no longer runs
2 participants