Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust styling of Dependencies page #3493

Merged
merged 2 commits into from
Dec 24, 2022
Merged

Adjust styling of Dependencies page #3493

merged 2 commits into from
Dec 24, 2022

Conversation

tacigar
Copy link
Member

@tacigar tacigar commented Dec 23, 2022 •
edited
Loading

  • Remove shadows
    • In the previous Dependencies page, there were a lot of shadows and felt a bit cluttered.
  • Remove AutoSizer.
    • Even though sizing can be done with just CSS, but AutoSizer was used
  • Nothing has changed in the logic.

Before

localhost_3000_zipkin_dependency_startTime=1671707527436 endTime=1671793927436 (1)

After

localhost_3000_zipkin_dependency_startTime=1671707527436 endTime=1671793927436

adjust-dependencies-styling.mov

tacigar
tacigar commented Dec 23, 2022
View reviewed changes
zipkin-lens/src/components/DependenciesPage/DependenciesGraph.tsx
xs={focusedNodeName ? 7 : 12}
className={classes.graphItemGrid}
>
<AutoSizer>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to use AutoSizer in this case.
Sizing can be done only with CSS.

@tacigar tacigar merged commit 8b61cfe into openzipkin:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvanbeek basvanbeek Awaiting requested review from basvanbeek

@jcchavezs jcchavezs Awaiting requested review from jcchavezs

@llinder llinder Awaiting requested review from llinder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tacigar