-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp trace page #3486
Revamp trace page #3486
Conversation
@@ -114,7 +114,10 @@ function formatDate(timestamp, utc) { | |||
} | |||
|
|||
export function mkDurationStr(duration) { | |||
if (duration === 0 || typeof duration === 'undefined') { | |||
if (duration === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in behavior makes a test fail... please fix the test because I think the update to this function makes sense.
[INFO] FAIL src/zipkin/trace.test.js
[INFO] ● mkDurationStr › should return empty string on zero duration
[INFO]
[INFO] expect(received).toBe(expected) // Object.is equality
[INFO]
[INFO] Expected: ""
[INFO] Received: "0ms"
[INFO]
[INFO] 354 | describe('mkDurationStr', () => {
[INFO] 355 | it('should return empty string on zero duration', () => {
[INFO] > 356 | expect(mkDurationStr(0)).toBe('');
[INFO] | ^
[INFO] 357 | });
[INFO] 358 |
[INFO] 359 | it('should return empty string on undefined duration', () => {
[INFO]
[INFO] at Object.<anonymous> (src/zipkin/trace.test.js:356:30)
[INFO]
[INFO]
[INFO] Test Suites: 1 failed, 23 passed, 24 total
[INFO] Tests: 1 failed, 233 passed, 234 total
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @basvanbeek
Fixed 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tacigar thank you for this awesome improvement to the Zipkin UI. I wholeheartedly approve it.
Thank you @basvanbeek !! |
This is awesome @tacigar ! |
This PR will
zipkin-revamp-tracepage.mp4