Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception on traceIds of length 15 #3471

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

rogierslag
Copy link
Contributor

References #3249 (comment)

From the linked PR it seems this exception was incorrectly added as the code would prepend a trace of length 15 with a single leading zero (just like it would add two leading zeros for a trace of length 14).

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me resists pun

depending on call-site this may need a version alignment/bump release in zipkin-reporter-java to make effective.

@codefromthecrypt codefromthecrypt merged commit bb0a133 into openzipkin:master Aug 18, 2022
@codefromthecrypt
Copy link
Member

thanks for the fix @rogierslag!

@jcchavezs
Copy link
Contributor

Shall we release a patch?

@codefromthecrypt
Copy link
Member

yeah and then have zipkin-reporter-java consume it. I'm not sure if something else should go into the release here or not (ex if the docker images which seem to have been updated recently, should be consumed here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants