Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiets startup logging #3253

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Quiets startup logging #3253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions docker/examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,13 @@ $ docker-compose -f docker-compose-mysql.yml up

## Kafka

The docker-compose configuration can be extended to host a test [Kafka broker](../collector/kafka/README.md)
and activate the [Kafka collector](../../zipkin-collector/kafka) using the `docker-compose-kafka.yml`
file. That file employs [docker-compose overrides](https://docs.docker.com/compose/extends/#multiple-compose-files)
to add a Kafka+ZooKeeper container and relevant settings.
You can collect traces from [Kafka](../collector/kafka/README.md) in addition to HTTP, using the
`docker-compose-kafka.yml` file. This configuration starts `zipkin` and `zipkin-kafka` in their
own containers.

To add Kafka configuration, run:
```bash
$ docker-compose -f docker-compose.yml -f docker-compose-kafka.yml up
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was broke

$ docker-compose -f docker-compose-kafka.yml up
```

Then configure the [Kafka sender](https://github.com/openzipkin/zipkin-reporter-java/blob/master/kafka11/src/main/java/zipkin2/reporter/kafka11/KafkaSender.java) using a `bootstrapServers` value of `host.docker.internal:9092` if your application is inside the same docker network or `localhost:19092` if not, but running on the same host.
Expand Down
4 changes: 2 additions & 2 deletions zipkin-collector/kafka/src/main/java/zipkin2/collector/kafka/KafkaCollectorWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
assignedPartitions.set(Collections.unmodifiableList(new ArrayList<>(partitions)));
}
});
LOG.info("Kafka consumer starting polling loop.");
LOG.debug("Kafka consumer starting polling loop.");
while (running.get()) {
final ConsumerRecords<byte[], byte[]> consumerRecords = kafkaConsumer.poll(Duration.of(1000, ChronoUnit.MILLIS));
LOG.debug("Kafka polling returned batch of {} messages.", consumerRecords.count());
Expand Down Expand Up @@ -117,7 +117,7 @@ public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
LOG.warn("Unexpected error in polling loop spans", e);
throw e;
} finally {
LOG.info("Kafka consumer polling loop stopped. Kafka consumer closed.");
LOG.debug("Kafka consumer polling loop stopped. Kafka consumer closed.");
}
}

Expand Down
3 changes: 3 additions & 0 deletions zipkin-server/src/main/resources/zipkin-server-shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,9 @@ logging:
pattern:
level: "%clr(%5p) %clr([%X{traceId}/%X{spanId}]){yellow}"
level:
# Hush MySQL related logs
org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor: 'WARN'
com.zaxxer.hikari.HikariDataSource: 'WARN'
# Don't print driver version in console output
com.datastax.oss.driver.internal.core.DefaultMavenCoordinates: 'WARN'
# We exclude Geo codec and Graph extensions to keep size down
Expand Down