Completes refactor of UI to v2 native #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last step where the UI no longer uses any v1 types. What it does now is a dual-pass where at first v2 spans are collected into events such that spans that share an ID can be in the same row. After that, it decorates them with positional details, such as where to put annotations or how wide the span line should be. fixes #2217
|
@openzipkin/ui so happy this is done.. so much work. I tested by viewing a netflix trace before and after as that's our most complex one. |
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
This is the last step where the UI no longer uses any v1 types. What it does now is a dual-pass where at first v2 spans are collected into events such that spans that share an ID can be in the same row. After that, it decorates them with positional details, such as where to put annotations or how wide the span line should be. fixes openzipkin#2217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step where the UI no longer uses any v1 types.
What it does now is a dual-pass where at first v2 spans are collected
into events such that spans that share an ID can be in the same row.
After that, it decorates them with positional details, such as where
to put annotations or how wide the span line should be.
fixes #2217