-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifies summary logic by not doing skew correction #2228
Conversation
The trace summary screen and individual trace screens are served by different data. At the moment, offsets are not considered when computing the trace duration broken down by service. Maybe it should be, but removing clock skew makes migration to v2 simpler and we can then revisit this logic. See #2217
I think that is good! I think that Sorry for newbie question 😞 |
This may indeed be a problem. I will look into it now as we don't have data yet to break this. |
The trace summary screen and individual trace screens are served by different data. At the moment, offsets are not considered when computing the trace duration broken down by service. Maybe it should be, but removing clock skew makes migration to v2 simpler and we can then revisit this logic. See openzipkin#2217
openzipkin#2229) In openzipkin#2228 my assumption was incorrect as @tacigar highlighted. This makes a test to ensure the logic stays the same for now.
The trace summary screen and individual trace screens are served by
different data. At the moment, offsets are not considered when computing
the trace duration broken down by service. Maybe it should be, but
removing clock skew makes migration to v2 simpler and we can then
revisit this logic.
See #2217