Fixed the multithreading issue which is happening when nrOfThread is mor... #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kristofa Please find the pull request for the fix: https://github.com/kristofa/brave/pull/64/files Let me know if you find any issues with it. Thanks, |
| for (int i = 1; i <= params.getNrOfThreads(); i++) { | ||
|
|
||
| //Creating a client provider for every spanProcessingThread. |
There was a problem hiding this comment.
It would be good if you could extract the client creation in a separate private method. This would make the constructor easier to read.
|
Thanks @raun007, if you can have a look at my remark. Once that's done I'll merge it. |
|
Hi @kristofa, I have made the change as suggested by you. Have a look. |
|
Thanks, merging. |
kristofa
added a commit
that referenced
this pull request
Feb 12, 2015
Fixed bug in ZipkinSpanCollector when nr of threads is > 1.
|
Thanks @kristofa |
|
@raun007 I made the brave release that contains this pull request. See here for release notes. It should become available in Maven Central shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e than 1. Refer #60