build: fixes bytecode level and updates build versions (#236) #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where we weren't releasing jars with the right bytecode level, due to a constant release=8. As we no longer can rely on RetroLambda to rewrite code, I've had to port things to the appropriate bytecode level manually. I also updated build deps that could be. Special note: Projects that optionally use types above their bytecode level *unset* maven.compiler.release in the release profile. This allows the project to compile classes not at the source level. This is used in brave core and okhttp, for example. Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
commented
Jan 6, 2024
| <main.java.version>1.6</main.java.version> | ||
| <maven.compiler.source>1.6</maven.compiler.source> | ||
| <maven.compiler.target>1.6</maven.compiler.target> | ||
| <!-- Clear the release tag, so that we can compile Platform without |
There was a problem hiding this comment.
example of clearing the tag.. this is what broke the bytecode version by accident last release, as the source/target were overridden by a hard-coded release property. Setting this to 6 breaks our ability to compile brave.internal.Platform, so clearing is the only way.
Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where we weren't releasing jars with the right bytecode level, due to a constant release=8. As we no longer can rely on RetroLambda to rewrite code, I've had to port things to the appropriate bytecode level manually. I also updated build deps that could be.
Special note: Projects that optionally use types above their bytecode level unset maven.compiler.release in the release profile. This allows the project to compile classes not at the source level. This is used in brave core and okhttp, for example.