systemd: correct path for awk (to /usr/bin/awk) #8513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The systemd scripts use awk bit /bin/awk which doesn't exist on most systems which use /usr/bin/awk (checked on Debian, Ubuntu, CentOS, Alpine). Signed-off-by: Chris Wedgwood <cw@f00f.org>
|
You are making the same mistake as the original author did. Do not hardcode binary paths in systemd units for standard directories. Using just "awk" is safe because systemd only looks in standard directories (sbin, bin, usr/bin...). |
|
@c0d3z3r0 thanks, I didn't see your PR. Closing. |
Codecov Report
@@ Coverage Diff @@
## master #8513 +/- ##
==========================================
- Coverage 78.55% 78.54% -0.02%
==========================================
Files 380 380
Lines 116324 116324
==========================================
- Hits 91375 91362 -13
- Misses 24949 24962 +13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
I noticed the systemd import scripts having problems and logging errors trying to access /bin/awk.
The spec requirement is /usr/bin/awk and the various systems I examined (debian, ubuntu, centos, alpine) all have /usr/bin/awk as opposed to /bin/awk.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.