Fix dirtying vdev config on with RO spa #8085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Nov 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #8085 +/- ##
==========================================
+ Coverage 78.44% 78.57% +0.13%
==========================================
Files 381 377 -4
Lines 114550 114518 -32
==========================================
+ Hits 89854 89988 +134
+ Misses 24696 24530 -166
Continue to review full report at Codecov.
|
ahrens
reviewed
Nov 7, 2018
This patch simply corrects an issue where vdev_dtl_reassess() could attempt to dirty the vdev config even when the spa was not elligable for writing. Signed-off-by: Tom Caputi <tcaputi@datto.com>
0c263a2 to
30d8adc
Compare
|
@ahrens addressed your comment |
ahrens
approved these changes
Nov 7, 2018
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
This patch simply corrects an issue where vdev_dtl_reassess() could attempt to dirty the vdev config even when the spa was not elligable for writing. Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tom Caputi <tcaputi@datto.com> Closes openzfs#8085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply corrects an issue where vdev_dtl_reassess()
could attempt to dirty the vdev config even when the spa was
not elligable for writing.
Signed-off-by: Tom Caputi tcaputi@datto.com
How Has This Been Tested?
Observed and verified with ztest.
Types of changes
Checklist:
Signed-off-by.