Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS 9862 - fix typo in comment in vdev_impl.h #8036

Closed
wants to merge 1 commit into from

Conversation

gmelikov
Copy link
Member

Authored by: Allan Jude allanjude@freebsd.org
Reviewed by: Matthew Ahrens mahrens@delphix.com
Reviewed by: Brian Behlendorf behlendorf1@llnl.gov
Approved by: Robert Mustacchi rm@joyent.com
Ported-by: George Melikov mail@gmelikov.ru

OpenZFS-issue: https://www.illumos.org/issues/9862
OpenZFS-commit: openzfs/openzfs@84927f5

Motivation and Context

Code base consistence.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Authored by: Allan Jude <allanjude@freebsd.org>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported-by: George Melikov <mail@gmelikov.ru>

OpenZFS-issue: https://www.illumos.org/issues/9862
OpenZFS-commit: openzfs/openzfs@84927f5

Signed-off-by: George Melikov <mail@gmelikov.ru>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 18, 2018
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #8036 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8036      +/-   ##
==========================================
+ Coverage   78.46%   78.48%   +0.02%     
==========================================
  Files         377      377              
  Lines      114404   114404              
==========================================
+ Hits        89765    89792      +27     
+ Misses      24639    24612      -27
Flag Coverage Δ
#kernel 78.76% <ø> (+0.05%) ⬆️
#user 67.21% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d43194...e8e69cd. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 18, 2018
ghfields pushed a commit to ghfields/zfs that referenced this pull request Oct 29, 2018
Authored by: Allan Jude <allanjude@freebsd.org>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed by: Tony Hutter <hutter2@llnl.gov>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported-by: George Melikov <mail@gmelikov.ru>

OpenZFS-issue: https://www.illumos.org/issues/9862
OpenZFS-commit: openzfs/openzfs@84927f52
Closes openzfs#8036
GregorKopka pushed a commit to GregorKopka/zfs that referenced this pull request Jan 7, 2019
Authored by: Allan Jude <allanjude@freebsd.org>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed by: Tony Hutter <hutter2@llnl.gov>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported-by: George Melikov <mail@gmelikov.ru>

OpenZFS-issue: https://www.illumos.org/issues/9862
OpenZFS-commit: openzfs/openzfs@84927f52
Closes openzfs#8036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants