ZTS: clean up leftover ibackup_trunc files #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
requested changes
Apr 12, 2018
| @@ -49,6 +49,7 @@ function cleanup | |||
| log_must zfs destroy -r $TESTPOOL/$TESTFS2 | |||
|
|
|||
| [[ -f $ibackup ]] && log_must rm -f $ibackup | |||
| [[ -f $ibackup_trunc ]] && log_must rm -f $ibackup_trunc | |||
There was a problem hiding this comment.
We should also change ibackup and ibackup_trunc's location to $TEST_BASE_DIR. Which is normally /var/tmp but it set by the buildbot to an alternate path for its testing.
zfs_receive_raw_incremental did not clean up ibackup_trunc.* files left over from running the test. Also changing the path of the ibackup files so they can be placed in the correct directories when /var/tmp is not the temporary directory. Signed-off-by: bunder2015 <omfgbunder@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7430 +/- ##
==========================================
+ Coverage 76.2% 76.35% +0.15%
==========================================
Files 330 330
Lines 104294 104289 -5
==========================================
+ Hits 79474 79633 +159
+ Misses 24820 24656 -164
Continue to review full report at Codecov.
|
dinatale2
approved these changes
Apr 13, 2018
behlendorf
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zfs_receive_raw_incremental did not clean up ibackup_trunc.* files left over from running the test.
Motivation and Context
Cleans up /var/tmp a little
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.