-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pools without a bootfs from BOOTFS variable creation #7089
Conversation
gimme a min to test this, should have a verified result some time tonight, @WoefulDerelict mind testing on a multi-pool system? |
3022fb1
to
10b8fd7
Compare
Not at all. I will nab this and test it shortly. |
Use the same method used in zfs-load-key. Signed-off-by: Matthew Thode <mthode@mthode.org>
10b8fd7
to
da91823
Compare
it looks like two things happened with systemd-236
|
Arch Linux appears to be forcing systemctl to /usr/bin/ along with the rest of the toolchain. Unfortunate that systemd-ask-password is failing. I've synced up to 522db29275b81c18c2bf53a95efa1aedeb13b428, cherry picked the patch and tested it on the same system with success. The system booted without the zfs-import-cache.service throwing any errors. |
/bin is a symlink to /usr/bin on Arch Linux systems so the proposed change is unlikely to break anything. |
is it a symlink within the dracut shell as well? (lsinitrd doesnt show that for me)
|
ok, my problem was that plymouth needed to be rebuilt with the new paths for systemd. this PR should be good to go. |
By default Arch Linux uses an initramfs CPIO image generated with mkinitcpio. /bin/systemctl resolves properly and zfs-import-cache.service starts without error. dracult is an option; however, not one I've tested or have something set up to test with. |
Codecov Report
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 75.6% 75.6% -0.01%
=========================================
Files 296 296
Lines 95661 95664 +3
=========================================
- Hits 72328 72327 -1
- Misses 23333 23337 +4
Continue to review full report at Codecov.
|
@prometheanfire @WoefulDerelict if I understand correctly from the comment above this PR has been tested and is ready to merge? Can you please confirm. |
confirmed here |
Use the same method used in zfs-load-key. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Llewelyn Trahaearn <WoefulDerelict@GMail.com> Signed-off-by: Matthew Thode <mthode@mthode.org> Closes openzfs#7089
Use the same method used in zfs-load-key.
Closes: #7085