Ignore non DMU_OST_ZFS and DMU_OST_ZVOL types #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or maybe I should be more specific and only |
|
I'd suggest the latter, only return -1 on |
Since the zpios and potentially other ZFS tests use the DMU_OST_OTHER type to label their datasets, the zpool and zfs commands should gracefully handle this type when it is encountered. This patch modifies the commands' behavior to ignore any datasets with a dds_type of DMU_OST_OTHER. Signed-off-by: Prakash Surya <surya1@llnl.gov> Closes #536
|
I agree, that sounds like a better approach. I've updated the branch and this pull request. |
|
Merged as commit ff998d8 |
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
Sep 26, 2023
…aster Merge remote-tracking branch '6.0/stage' into 'master'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dataset is successfully opened with the zpool or zfs commands, and
it is found to have a dds_type of neither DMU_OST_ZFS nor DMU_OST_ZVOL,
the command will abort(). This patch changes that behavior. Rather than
calling abort(), now, the dataset in question is simply ignored.
Signed-off-by: Prakash Surya surya1@llnl.gov
Closes #536