Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illumos 6288 dmu_buf_will_dirty could be faster #3987

Closed

Conversation

kernelOfTruth
Copy link
Contributor

Illumos 6288 dmu_buf_will_dirty could be faster
Reviewed by: George Wilson george.wilson@delphix.com
Reviewed by: Paul Dagnelie pcd@delphix.com
Reviewed by: Justin Gibbs gibbs@scsiguy.com
Reviewed by: Richard Elling Richard.Elling@RichardElling.com
Approved by: Robert Mustacchi rm@joyent.com

References:
https://www.illumos.org/issues/6288 dmu_buf_will_dirty could be faster
illumos/illumos-gate@0f2e7d0

Porting notes:
account for 'warning: ISO C90 forbids mixed declarations and code'
and move

dbuf_dirty_record_t *dr;

to the beginning of the block of code

@dmu_buf_will_dirty(dmu_buf_t *db_fake, dmu_tx_t *tx)

.

Ported-by: kernelOfTruth kerneloftruth@gmail.com

@kernelOfTruth
Copy link
Contributor Author

I hope this helps, had cases (also just recently) when deleting files took exceptionally long,

this might help ...

@kernelOfTruth
Copy link
Contributor Author

/var/tmp/portage/sys-fs/zfs-kmod-9999-r1/work/zfs-kmod-9999/module/zfs/dbuf.c: In function ‘dmu_buf_will_dirty’:
/var/tmp/portage/sys-fs/zfs-kmod-9999-r1/work/zfs-kmod-9999/module/zfs/dbuf.c:1575:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  dbuf_dirty_record_t *dr;

besides that:
compile-tested [OK]

@kernelOfTruth kernelOfTruth force-pushed the zfs_master_14.10.2015+6288 branch from 640fead to 6b5e681 Compare November 12, 2015 20:35
@kernelOfTruth kernelOfTruth force-pushed the zfs_master_14.10.2015+6288 branch from 6b5e681 to 4214a4f Compare November 21, 2015 19:02
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Justin Gibbs <gibbs@scsiguy.com>
Reviewed by: Richard Elling <Richard.Elling@RichardElling.com>
Approved by: Robert Mustacchi <rm@joyent.com>

References:
https://www.illumos.org/issues/6288 dmu_buf_will_dirty could be faster
illumos/illumos-gate@0f2e7d0

Porting notes:
account for 'warning: ISO C90 forbids mixed declarations and code'
and move

dbuf_dirty_record_t *dr;

to the beginning of the block of code

@dmu_buf_will_dirty(dmu_buf_t *db_fake, dmu_tx_t *tx)

.

Ported-by: kernelOfTruth kerneloftruth@gmail.com
@kernelOfTruth kernelOfTruth force-pushed the zfs_master_14.10.2015+6288 branch from 4214a4f to 4fbf4bc Compare December 10, 2015 19:19
@kernelOfTruth
Copy link
Contributor Author

rebased to zfs_master of December 9th 2015,

fixed the ISO C90 warning

@behlendorf
Copy link
Contributor

5a28a97 Illumos 6288 - dmu_buf_will_dirty could be faster

@behlendorf behlendorf closed this Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants