Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all NFS functions as PF_FSTRANS #3293

Closed
wants to merge 1 commit into from

Conversation

behlendorf
Copy link
Contributor

Prevent deadlocks by disabling direct reclaim during all NFS calls.
This is related to 40d06e3.

Signed-off-by: Brian Behlendorf behlendorf1@llnl.gov
Issue #3225

@dweeezil
Copy link
Contributor

LGTM

@behlendorf
Copy link
Contributor Author

Refreshed and expanded to cover the xattr paths which also can suffer from this issue.

@dweeezil
Copy link
Contributor

@behlendorf Should we also do the same with:

  • zpl_put_super
  • zpl_sync_fs
  • zpl_statfs
  • zpl_remount_fs
  • zpl_fill_super
  • zpl_prune_sb (?)
  • zpl_shares_iterate
  • zpl_shares_getattr

for completeness?

Prevent deadlocks by disabling direct reclaim during all NFS, xattr,
ctldir, and super function calls.  This is related to 40d06e3.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#3225
@behlendorf
Copy link
Contributor Author

@dweeezil yes I think that would be prudent. I've refreshed the patch to include them.

@behlendorf
Copy link
Contributor Author

Merged as:

7fad629 Mark additional functions as PF_FSTRANS

@behlendorf behlendorf closed this Apr 17, 2015
@behlendorf behlendorf deleted the nfs-fstrans branch April 19, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants