illumos 4088 - use after free in arc_release() #2162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4088 use after free in arc_release() Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com> Approved by: Dan McDonald <danmcd@nexenta.com> Ported by: Tim Chase <tim@chase2k.com> From the illumos issue: A race-induced use after free occurs in arc_release() where the ARC header is used outside the critical section protected by the hash_lock.
|
This looks like a useful patch. I'm wondering if #2154 might be caused by this. |
|
Nice find. I took a look at the code and analysis in the Illumos issue and I agree completely that this is is an important bug fix. Feel free to add my |
ryao
pushed a commit
to ryao/zfs
that referenced
this pull request
Apr 9, 2014
4088 use after free in arc_release() Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com> Approved by: Dan McDonald <danmcd@nexenta.com> References: https://www.illumos.org/issues/4088 illumos/illumos-gate@ccc22e1 From the illumos issue: A race-induced use after free occurs in arc_release() where the ARC header is used outside the critical section protected by the hash_lock. Ported by: Tim Chase <tim@chase2k.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <ryao@gentoo.org> Closes openzfs#2162 Conflicts: module/zfs/arc.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4088 use after free in arc_release()
Reviewed by: Matthew Ahrens mahrens@delphix.com
Reviewed by: Garrett D'Amore garrett@damore.org
Reviewed by: Saso Kiselkov skiselkov.ml@gmail.com
Approved by: Dan McDonald danmcd@nexenta.com
Ported by: Tim Chase tim@chase2k.com
From the illumos issue:
A race-induced use after free occurs in arc_release() where the ARC header
is used outside the critical section protected by the hash_lock.