Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct level handling in zstream recompress. #16198

Merged
merged 2 commits into from
May 16, 2024
Merged

Correct level handling in zstream recompress. #16198

merged 2 commits into from
May 16, 2024

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

sscanf returns number of items parsed on success and EOF on failure.

As-is, this errors on all valid options, and succeeds on all invalid options.

Description

How Has This Been Tested?

What's a test?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rincebrain
Correct level handling in zstream recompress.
1ccd214 
sscanf returns number of items parsed on success and EOF on failure.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
robn
robn approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun find. Clearly a much-used and -loved feature.

I might have taken the opportunity to convert it to strotul(), but instead I've just added destroy *scanf() to my todo list.

pcd1193182
pcd1193182 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@pcd1193182 pcd1193182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 15, 2024
@rincebrain
Empty
86a0e59 
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 15, 2024
@behlendorf behlendorf merged commit a043b60 into openzfs:master May 16, 2024
23 of 24 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@rincebrain @lundman
Correct level handling in zstream recompress.
70b5d09 
sscanf returns number of items parsed on success and EOF on failure.

Reviewed-by: Adam Moss <c@yotes.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#16198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdmoss adamdmoss adamdmoss left review comments

@robn robn robn approved these changes

@pcd1193182 pcd1193182 pcd1193182 approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rincebrain @robn @pcd1193182 @behlendorf @adamdmoss