Ensure BLK_OPEN_EXCL is defined in HAVE_BLKDEV_GET_BY_PATH_4ARG case #15688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
b52eb16 to
c3f91d4
Compare
behlendorf
reviewed
Dec 19, 2023
There was a problem hiding this comment.
The code change looks good to me. Can you just address the two style warning.
-
Add your "Signed-off-by" to the commit and force up the the PR.
git commit --amend -s. -
A trivial cstyle warning.
make: *** [Makefile:14230: commitcheck] Error 1
make: *** Waiting for unfinished jobs....
./module/os/linux/zfs/vdev_disk.c: 228: #define followed by space instead of tab
On some systems we already have blkdev_get_by_path() with 4 args but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined. Signed-off-by: Dominik Heidler <dheidler@suse.de>
c3f91d4 to
d56320c
Compare
behlendorf
approved these changes
Dec 20, 2023
13 tasks
|
Replaced by #15692. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
See #15099 (comment)