Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macos: m4 changes #15523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Macos: m4 changes #15523

wants to merge 1 commit into from

Conversation

andrewc12
Copy link
Contributor

@andrewc12 andrewc12 commented Nov 14, 2023 •
edited
Loading

Motivation and Context

Description

Additions to the m4 scripts that help us build openzfs on macos

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@andrewc12 andrewc12 marked this pull request as ready for review November 14, 2023 08:22
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 17, 2023
@andrewc12
Copy link
Contributor Author

andrewc12 commented Nov 28, 2023 •
edited
Loading

Has anyone had a chance to look at this yet?

@andrewc12 @lundman
Macos: m4 changes
9a390d0 
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
Co-authored-by: Jorgen Lundman <lundman@lundman.net>
@andrewc12 andrewc12 changed the title m4 changes for macos Macos: m4 changes Jan 17, 2024
@andrewc12 andrewc12 mentioned this pull request Jan 18, 2024
Open
13 tasks
@andrewc12
Copy link
Contributor Author

@behlendorf are there any blockers to this I can work on?

@andrewc12
Copy link
Contributor Author

@behlendorf I'm going to be going back to university soon and I won't be able to work on anything for a few months.

I feel like I'm not making any progress with getting anything merged.

@andrewc12
Copy link
Contributor Author

@behlendorf any news?

@andrewc12
Copy link
Contributor Author

@behlendorf I'm going on break from University soon. Is there anything I should work on?

zyv
zyv reviewed May 15, 2024
View reviewed changes
config/zfs-build.m4
@@ -606,6 +609,7 @@ AC_DEFUN([ZFS_AC_DEFAULT_PACKAGE], [
ubuntu) initconfdir=/etc/default ;;
debian) initconfdir=/etc/default ;;
freebsd) initconfdir=$sysconfdir/rc.conf.d;;
apple) initconfdir=${prefix}/etc/launchd/launchd.d/ ;;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra tailing slash?

@yurikoles
Copy link

I see the wrong spelling: Macos should be spelled as macOS.

@tonyhutter
Copy link
Contributor

@andrewc12 so sorry this fell off our radar! I'll take a look.

tonyhutter
tonyhutter reviewed Feb 19, 2025
View reviewed changes
config/kernel-macos-headers.m4
AC_MSG_RESULT($machkernel)


dnl More Generic names:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a #?

dnl # More Generic names

@tonyhutter
Copy link
Contributor

@andrewc12 side note - now that we've switched from buildbot to github runners for testing, it would be theoretically possible to add an OSX runner to at least run ./configure on OSX. Github runners currently support Intel and M1 architectures (https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners). I'm not saying you need to do that as part of this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyv zyv zyv left review comments

@tonyhutter tonyhutter tonyhutter left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewc12 @yurikoles @tonyhutter @zyv @behlendorf