Work around Raspberry Pi kernel packaging oddities #14747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian and Ubuntu and friends, you get something like "linux-image-$(uname -r)" and "linux-headers-$(uname -r)" you can put a Depends on. On Raspberry Pi OS, you get "raspberrypi-kernel" and "raspberrypi-kernel-headers", with version numbers like 20230411. There is not, as far as I can tell, a reasonable way to map that to a kernel version short of reaching out and digging around in the changelogs or Makefile, so just special-case it so the packages don't fail to install at install time. They still might not build if the versions don't match, but I don't see a way to do anything about that... Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
behlendorf
approved these changes
Apr 18, 2023
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Apr 30, 2023
On Debian and Ubuntu and friends, you get something like "linux-image-$(uname -r)" and "linux-headers-$(uname -r)" you can put a Depends on. On Raspberry Pi OS, you get "raspberrypi-kernel" and "raspberrypi-kernel-headers", with version numbers like 20230411. There is not, as far as I can tell, a reasonable way to map that to a kernel version short of reaching out and digging around in the changelogs or Makefile, so just special-case it so the packages don't fail to install at install time. They still might not build if the versions don't match, but I don't see a way to do anything about that... Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#14745 Closes openzfs#14747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian and Ubuntu and friends, you get something like "linux-image-$(uname -r)" and "linux-headers-$(uname -r)" you can put a Depends on.
On Raspberry Pi OS, you get "raspberrypi-kernel" and "raspberrypi-kernel-headers", with version numbers like 20230411-1.
There is not, as far as I can tell, a reasonable way to map that to a kernel version short of reaching out and digging around in the changelogs or Makefile, so just special-case it so the packages don't fail to install at install time. They still might not work if the versions don't match, but I don't see a way to do anything about that...
Motivation and Context
Someone reported that trying to build the native-deb packages on the artist formerly known as Raspbian broke at install time, and it turned out to be from an unmeetable dependency on linux-image-$(uname -r).
Description
Just add a special case for Raspbian to not check the exact version built against, otherwise this can never work.
It still might not work, but since using Raspbian you can't have multiple kernel packages installed at a time, this seems like the best you're going to get, unless you just add a hard dependency on the exact version and break on, say, 20221104-2...
How Has This Been Tested?
It built for the person originally reporting the problem.
Types of changes
Checklist:
Signed-off-by.