Don't leak packed recieved proprties #14197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When local properties (e.g., from -o and -x) are provided, don't leak the packed representation of the recieved properties due to variable reuse. Signed-off-by: Brooks Davis <brooks.davis@sri.com>
behlendorf
approved these changes
Nov 29, 2022
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 30, 2022
When local properties (e.g., from -o and -x) are provided, don't leak the packed representation of the received properties due to variable reuse. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brooks Davis <brooks.davis@sri.com> Closes openzfs#14197
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 1, 2022
When local properties (e.g., from -o and -x) are provided, don't leak the packed representation of the received properties due to variable reuse. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brooks Davis <brooks.davis@sri.com> Closes openzfs#14197
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Dec 16, 2022
When local properties (e.g., from -o and -x) are provided, don't leak the packed representation of the received properties due to variable reuse. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brooks Davis <brooks.davis@sri.com> Closes openzfs#14197
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Dec 17, 2022
When local properties (e.g., from -o and -x) are provided, don't leak the packed representation of the received properties due to variable reuse. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brooks Davis <brooks.davis@sri.com> Closes openzfs#14197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The recv implementation in libzfs packs up to two sets of properties to pass by ioctl, but only frees one. Found by inspection of
fnvlist_packed()calls.Description
Use a separate variable for each packed nvlist and free either if allocated.
How Has This Been Tested?
It's trivial and CI will run the test suite.
Types of changes
Checklist:
Signed-off-by.