Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logapi: cat output file instead of printing #11515

Closed
wants to merge 2 commits into from
Closed

logapi: cat output file instead of printing #11515

wants to merge 2 commits into from

Conversation

wca
Copy link
Contributor

@wca wca commented Jan 25, 2021

Motivation and Context

This avoids globbing together multiple lines in the log, if you happen to
specify LOGAPI_DEBUG because you want to see it.

Description

Instead of printing the output, cat the log file, so its contents appear unmolested in the test output.

How Has This Been Tested?

ZTS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

wca added 2 commits January 24, 2021 18:02
@wca
spa_export_common: refactor common exit points
910317f 
This fixes a bug in which spa_is_exporting wasn't cleared in some cases.

Signed-off-by:	Will Andrews <will@firepipe.net>
@wca
logapi: cat output file instead of printing
0729aca 
This avoids globbing together multiple lines in the log, if you happen to
specify LOGAPI_DEBUG because you want to see it.

Signed-off-by:	Will Andrews <will@firepipe.net>
@wca wca mentioned this pull request Jan 25, 2021
Open
12 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jan 25, 2021
@behlendorf
Copy link
Contributor

Merged the logapi change from this PR.

jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@wca @jsai20
logapi: cat output file instead of printing
8344537 
This avoids globbing together multiple lines in the log, if you happen
to specify LOGAPI_DEBUG because you want to see it.

Signed-off-by:	Will Andrews <will@firepipe.net>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#11515
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@wca
logapi: cat output file instead of printing
0fff2bc 
This avoids globbing together multiple lines in the log, if you happen
to specify LOGAPI_DEBUG because you want to see it.

Signed-off-by:	Will Andrews <will@firepipe.net>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#11515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wca @behlendorf