spa_export_common: refactor common exit points #11514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in which spa_is_exporting wasn't cleared in some cases. Signed-off-by: Will Andrews <will@firepipe.net>
12 tasks
behlendorf
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
I'm fine with the refactoring since I know we're going to need to for subsequent changes. But I think the description is a little misleading since it does look like in both cases here we are correctly clearing spa_is_exporting. If you like I can update the comment accordingly when merging.
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Create a common exit point for spa_export_common (a very long function), which avoids missing steps on failure. This work is helpful for the planned forced pool export changes. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Will Andrews <will@firepipe.net> Closes openzfs#11514
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Create a common exit point for spa_export_common (a very long function), which avoids missing steps on failure. This work is helpful for the planned forced pool export changes. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Will Andrews <will@firepipe.net> Closes openzfs#11514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which spa_is_exporting wasn't cleared in some cases.
Signed-off-by: Will Andrews will@firepipe.net
Motivation and Context
It's a bug fix.
Description
Create a common exit point for spa_export_common (a very long function), which avoids missing steps on failure.
How Has This Been Tested?
ZTS
Types of changes
Checklist:
Signed-off-by.