Note that keys must be loaded if encrypted datasets exist for top-level vdevs to be removed #10948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is relation to openzfs#10939
behlendorf
approved these changes
Sep 21, 2020
ahrens
approved these changes
Sep 21, 2020
behlendorf
pushed a commit
that referenced
this pull request
Oct 1, 2020
The error returned by `zpool remove` when the encryption keys aren't loaded isn't very helpful. Furthermore, the man pages make no mention that the keys need to be loaded. This change doesn't resolve the error message but it does update the man page to mention this requirement. Authored-by: grodik <pat@litke.dev> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #10939 Closes #10948
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The error returned by `zpool remove` when the encryption keys aren't loaded isn't very helpful. Furthermore, the man pages make no mention that the keys need to be loaded. This change doesn't resolve the error message but it does update the man page to mention this requirement. Authored-by: grodik <pat@litke.dev> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#10939 Closes openzfs#10948
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
The error returned by `zpool remove` when the encryption keys aren't loaded isn't very helpful. Furthermore, the man pages make no mention that the keys need to be loaded. This change doesn't resolve the error message but it does update the man page to mention this requirement. Authored-by: grodik <pat@litke.dev> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#10939 Closes openzfs#10948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is relation to #10939
Motivation and Context
The error returned when keys aren't loaded when a top-level vdev is attempted to be removed isn't descriptive, and the man pages make no note that keys need to be loaded. This MR obviously doesn't resolve the error message, but at least the man pages will make a note that keys need to be loaded
Description
Just a quick man page addition to ensure that it's clear that keys need to be loaded for encrypted datasets to be able to remove a top-level vdev
How Has This Been Tested?
N/A
Types of changes
Checklist:
Signed-off-by.