Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict autotools API checks #999

Closed
ryao opened this issue Sep 30, 2012 · 3 comments
Closed

Strict autotools API checks #999

ryao opened this issue Sep 30, 2012 · 3 comments
Labels
Type: Building Indicates an issue related to building binaries
Milestone

Comments

@ryao
Copy link
Contributor

ryao commented Sep 30, 2012

Currently, many configure script checks for API changes make assumptions that if one interface is not used, the other must be used. Unfortunately, that assumption causes problems should the interface change again. Building --with-debug will address that through a compile time failure, but few end users do, which can result in difficult to debug runtime failures that are rather frustrating for users (e.g. issue #843). We can address that by changing the existing checks to check all known cases and forcing a failure if no known case is detected. Once that is done, all future configure script checks should be required to follow the same standard.

This is also related to issue #582, which could probably be tackled at the same time.

@ryao
Copy link
Contributor Author

ryao commented Oct 3, 2012

Issue #1004 would have been easier to diagnose if this was in place. It also seems that it would be wise to run all checks even if a failure is detected occurs so that we can obtain a list of issues more easily.

@behlendorf
Copy link
Contributor

This is still a good idea, time permitting.

@behlendorf behlendorf removed this from the 0.7.0 milestone Oct 6, 2014
@behlendorf behlendorf added this to the 1.0.0 milestone Mar 26, 2016
@behlendorf
Copy link
Contributor

This remains a good idea if someone wants to work on it, but the existing system has been working well for several years now.

pcd1193182 pushed a commit to pcd1193182/zfs that referenced this issue Sep 26, 2023
…zfs#999)

Bumps [rustversion](https://github.com/dtolnay/rustversion) from 1.0.12 to 1.0.13.
- [Release notes](https://github.com/dtolnay/rustversion/releases)
- [Commits](dtolnay/rustversion@1.0.12...1.0.13)

---
updated-dependencies:
- dependency-name: rustversion
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Development

No branches or pull requests

2 participants