-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remake_initrd needs to be yes #849
Comments
This is the workaround I am using ATM:
|
Good tip, I've assigned the issue to Prakash to follow up with an updated patch when he gets the time. |
But if we're not booting from ZFS, we don't need zfs in the initrd and therefor don't need to remake the initrd... So setting this to yes globaly (for everyone), might be a bad thing... |
@behlendorf Should we close this as 'wont-fix' (considering it might be a bad thing to globally for everyone)? Or should we retag it as 'Documentation' and document it somewhere (where in such case - people don't read documentation :)? |
Turbo, Frans, @behlendorf , if you are not booting from ZFS, then the initrd won't contain ZFS, so remaking the initrd is an entirely harmless no-op. NOT remaking the initrd, on the other hand, renders the system unbootable, if you were installing these packages to a ZFS-based chroot you intend to boot from during next boot. |
I'm not sure it's kosher to remake a/the initrd if there's no need for it. |
@Rudd-O I agree this should default to 'yes' assuming all the required dependencies are installed. But since the zfs-dracut package is optional we're going to need to do something slightly more complicated. If you look at the Ubuntu DKMS package @dajhorn does the following which looks like a nice clean way to handle this.
If we could get a similar solution tested I have no objection to merging it. |
Closing. This is an issue for the distribution packaging. |
What about the same thing in the case of ZFS DKMS on Fedora and Red Hat? In these cases, clearly this repo is the source of the packaging. Over here, whenever I upgrade the ZFS DKMS packages, I end up having to remake the initrd right after the RPM install, because the initrds will contain either no ZFS or the prior ZFS version. |
Addresses a small conflict in zil.c during the last automated merge
In the DKMS branch, the code in dkms.conf that says
REMAKE_INITRD="no"
needs to be yes. The reason it needs to be yes is because ZFS support needs to be included into the initial RAM disk after compilation. Otherwise, ZFS fails to load upon boot, rendering ZFS-on-root setups unbootable.
Same goes for spl's dkms.conf.
Thanks in advance :-)
The text was updated successfully, but these errors were encountered: