-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arc_summary.py crashes with -d option when called with Python 3 #6849
Comments
After a bit of testing: Python2 returns a string as the first element of the tuple produced by |
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 8, 2017
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3 (see issue openzfs#6849) Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
13 tasks
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 9, 2017
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3 (see issue openzfs#6849). Rewrite of call to "modinfo zfs -0". Removes variable type information from description ("(uint)", "(int)", etc). Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 10, 2017
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3 (see issue openzfs#6849) Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 10, 2017
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3 (see issue openzfs#6849) Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 10, 2017
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3 (see issue openzfs#6849) Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this issue
Jan 16, 2018
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com> Closes openzfs#6849 Closes openzfs#6850
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this issue
Jan 18, 2018
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com> Closes openzfs#6849 Closes openzfs#6850
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this issue
Jan 18, 2018
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com> Closes openzfs#6849 Closes openzfs#6850
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this issue
Jan 19, 2018
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com> Closes openzfs#6849 Closes openzfs#6850
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this issue
Jan 29, 2018
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com> Closes openzfs#6849 Closes openzfs#6850
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this issue
Feb 13, 2018
Prevents arc_summary.py crashing when called with parameter -d or long form --description with Python3. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com> Closes openzfs#6849 Closes openzfs#6850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System information
Describe the problem you're observing
arc_summary.py crashes when called with the option -d with Python 3. The problem does no occur with Python 2.
Describe how to reproduce the problem
Run
python3 arc_summary.py -d
Include any warning/errors/backtraces from the system logs
Tentative Diagnosis
Python 3 changed the way encoding is handled with files (see https://docs.python.org/3.0/whatsnew/3.0.html#text-vs-data-instead-of-unicode-vs-8-bit). It is probable that the pipe called here now returns the wrong sort of data.
The text was updated successfully, but these errors were encountered: