Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc_evict() stack size #3377

Closed
chrisrd opened this issue May 6, 2015 · 0 comments
Closed

arc_evict() stack size #3377

chrisrd opened this issue May 6, 2015 · 0 comments

Comments

@chrisrd
Copy link
Contributor

chrisrd commented May 6, 2015

With debugging enabled and depending on your kernel config, the size of arc_buf_hdr_t can blow out the stack of arc_evict() to greater than 1024 bytes:

CC [M]  zfsonlinux/zfs/module/zfs/../../module/zfs/arc.o
zfsonlinux/zfs/module/zfs/../../module/zfs/arc.c: In function 'arc_evict':
zfsonlinux/zfs/module/zfs/../../module/zfs/arc.c:1978:1: error: the frame size of 1184 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
cc1: all warnings being treated as errors
make[5]: *** [zfsonlinux/zfs/module/zfs/../../module/zfs/arc.o] Error 1
chrisrd added a commit to chrisrd/zfs that referenced this issue May 6, 2015
@chrisrd
arc_evict(): reduce stack usage using kmem_zalloc()
658d451 
With debugging enabled and depending on your kernel config, the size of
arc_buf_hdr_t can blow out the stack of arc_evict() to greater than 1024
bytes. Let's avoid this.

Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#3377
chrisrd added a commit to chrisrd/zfs that referenced this issue May 6, 2015
@chrisrd
arc_evict, arc_evict_ghost: reduce stack usage using kmem_zalloc
312b7be 
With debugging enabled and depending on your kernel config, the size of
arc_buf_hdr_t can blow out the stack of arc_evict() and arc_evict_ghost()
to greater than 1024 bytes. Let's avoid this.

Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#3377
@chrisrd chrisrd mentioned this issue May 6, 2015
Closed
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this issue May 10, 2015
@chrisrd @kernelOfTruth
arc_evict, arc_evict_ghost: reduce stack usage using kmem_zalloc
f62d1ff 
With debugging enabled and depending on your kernel config, the size of
arc_buf_hdr_t can blow out the stack of arc_evict() and arc_evict_ghost()
to greater than 1024 bytes. Let's avoid this.

Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3377

-------------------------------------------------------

adapt to changes from 2129, ABD
dasjoe pushed a commit to dasjoe/zfs that referenced this issue May 24, 2015
@chrisrd @dasjoe
arc_evict, arc_evict_ghost: reduce stack usage using kmem_zalloc
bd804df 
With debugging enabled and depending on your kernel config, the size of
arc_buf_hdr_t can blow out the stack of arc_evict() and arc_evict_ghost()
to greater than 1024 bytes. Let's avoid this.

Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

arc_evict, arc_evict_ghost: reduce stack usage using kmem_zalloc chrisrd/zfs
1 participant
@chrisrd