Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to add slog device when bootfs variable is set #1631

Closed
likewhoa opened this issue Aug 7, 2013 · 1 comment
Closed

Unable to add slog device when bootfs variable is set #1631

likewhoa opened this issue Aug 7, 2013 · 1 comment
Milestone
0.6.3

Comments

@likewhoa
Copy link

likewhoa commented Aug 7, 2013

When trying to add an slog device I get the following error message.

cannot add to 'pool': root pool can not have multiple vdevs or separate logs

The only way around this is by running the following command zpool set bootfs= pool and then setting it back once the slog is added.
@ryao
Copy link
Contributor

ryao commented Aug 7, 2013

This is caused by an if statement in zfs_ioc_vdev_add(). It is an artifact that we inherited from Solaris, which implemented root pool support at a time when the bootloader did not support multiple devices. The most common bootloader in use on Linux is GRUB2. As soon as we have verified that GRUB2 has no problems with such pools, it should be safe to remove this.

unya pushed a commit to unya/zfs that referenced this issue Dec 13, 2013
@behlendorf @unya
Remove the slog restriction on bootfs pools
96e2978 
Under Linux this restriction does not apply because we have access
to all the required devices.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#1631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.3
Development

No branches or pull requests
2 participants
@ryao @likewhoa