Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpool add allows mismatching redundancy after vdev removal #13705

Closed
speed47 opened this issue Jul 29, 2022 · 1 comment
Closed

zpool add allows mismatching redundancy after vdev removal #13705

speed47 opened this issue Jul 29, 2022 · 1 comment
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@speed47
Copy link
Contributor

speed47 commented Jul 29, 2022 •
edited
Loading

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 22.04 LTS
Kernel Version 5.15.53 (vanilla)
Architecture x86_64
OpenZFS Version 2.1.5

Describe the problem you're observing

It is possible to (involuntarily) bypass the "mismatching redundancy" security check of zpool add after a vdev has been removed from the zpool.
This is due to the fact that once indirect vdevs are present, the internal get_replication() check fails, even as the pool has still a correct redundancy. Any subsequent zpool modification command will be allowed even if it actually changes the redundancy as the zpool command will make the assumption that the redundancy is already broken, as per:

zfs/cmd/zpool/zpool_vdev.c

Lines 810 to 821 in e8cf3a4

/*
* If we have a current pool configuration, check to see if it's
* self-consistent. If not, simply return success.
*/
if (config != NULL) {
nvlist_t *nvroot;
verify(nvlist_lookup_nvlist(config, ZPOOL_CONFIG_VDEV_TREE,
&nvroot) == 0);
if ((current = get_replication(nvroot, B_FALSE)) == NULL)
return (0);
}

Describe how to reproduce the problem

for i in a b c d e f special; do truncate -s 1G /dev/shm/$i; done
zpool create test mirror /dev/shm/{a,b} mirror /dev/shm/{c,d}
zpool add test special /dev/shm/special # this fails as it should ("mismatched replication level: pool uses mirror and new vdev is file")
zpool add test mirror /dev/shm/{e,f}
zpool remove test mirror-1 # corresponding to /dev/shm/{c,d}
zpool add test special /dev/shm/special # it works, it shouldn't

After the zpool remove, a manual call to get_redundancy() shows failure, while it should report the pool has having a correct redundancy:

invalid vdev specification
use '-f' to override the following errors:
mismatched replication level: both mirror and indirect vdevs are present
mismatched replication level: both indirect and mirror vdevs are present

We end up with this configuration:

# zpool status test
  pool: test
 state: ONLINE
remove: Removal of vdev 1 copied 62.5K in 0h0m, completed on Fri Jul 29 11:19:36 2022
        144 memory used for removed device mappings
config:

        NAME                STATE     READ WRITE CKSUM
        test                ONLINE       0     0     0
          mirror-0          ONLINE       0     0     0
            /dev/shm/a      ONLINE       0     0     0
            /dev/shm/b      ONLINE       0     0     0
          mirror-2          ONLINE       0     0     0
            /dev/shm/e      ONLINE       0     0     0
            /dev/shm/f      ONLINE       0     0     0
        special 
          /dev/shm/special  ONLINE       0     0     0

...which is highly dangerous, and we didn't override any check by using -f at any point.
@speed47 speed47 added the Type: Defect Incorrect behavior (e.g. crash, hang) label Jul 29, 2022
@speed47
Copy link
Contributor Author

speed47 commented Jul 29, 2022

This fixes the problem, but I'm not sure if it's okay to just ignore indirect vdevs entirely for the redundancy check. I'll have to run the ZFS tests to be sure.
master...speed47:zfs:zpool_redundancy

speed47 added a commit to speed47/zfs that referenced this issue Jul 31, 2022
@speed47
zpool: fix redundancy check after vdev removal
eadad4c 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
@speed47 speed47 mentioned this issue Jul 31, 2022
Merged
13 tasks
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@speed47 @nicman23
zpool: fix redundancy check after vdev removal
febc02a 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@speed47 @nicman23
zpool: fix redundancy check after vdev removal
e0dbf60 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Sep 13, 2022
@speed47 @lundman
zpool: fix redundancy check after vdev removal
62ca404 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
beren12 pushed a commit to beren12/zfs that referenced this issue Sep 19, 2022
@speed47 @beren12
zpool: fix redundancy check after vdev removal
7d24fe7 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
b1143da 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
0a25777 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
50359d3 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
acd8574 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
2300eda 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
437bc6c 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
bd0d3dd 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
e1e9e09 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
497cd6c 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
618e6f3 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
1a689bd 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
b4d1781 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
749570b 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
7ea4281 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
3da325d 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
4666fa5 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
a411607 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
c413aac 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
33e8163 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
ec322a6 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
54fcbbc 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
95886b1 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
453bff4 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
88db74f 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
8e207f1 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
8e11a6b 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
f337d16 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
92772fc 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
114bbdb 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
013cac0 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
cf3feff 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
bee639c 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@speed47 @andrewc12
zpool: fix redundancy check after vdev removal
7c49539 
The presence of indirect vdevs was confusing get_redundancy(), which
considered a pool with e.g. only mirror top-level vdevs and at least
one indirect vdev (due to the removal of a previous vdev) as already
having a broken redundancy, which is not the case. This lead to the
possibility of compromising the redundancy of a pool by adding
mismatched vdevs without requiring the use of `-f`, and with no
visible notice or warning.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stéphane Lesimple <speed47_github@speed47.net>
Closes openzfs#13705
Closes openzfs#13711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@speed47