-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add missing zfs_ioc_objset_stats() error handling
Interestingly this looks like an upstream bug as well. If for some reason we are unable to get a zvols statistics, because perhaps the zpool is hopelessly corrupt, we would trigger the VERIFY. This commit adds the proper error handling just to propagate the error back to user space. Now the user space tools still must handle this properly but in the worst case the tool will crash or perhaps have some missing output. That's far far better than crashing the host. Closes #45
- Loading branch information
1 parent
b3c82b1
commit 89f0abf
Showing
3 changed files
with
16 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
master |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
From: Brian Behlendorf <behlendorf1@llnl.gov> | ||
Subject: [PATCH] fix zfs_ioc_objset_stats | ||
|
||
Interestingly this looks like an upstream bug as well. If for some | ||
reason we are unable to get a zvols statistics, because perhaps the | ||
zpool is hopelessly corrupt, we would trigger the VERIFY. This | ||
commit adds the proper error handling just to propagate the error | ||
back to user space. Now the user space tools still must handle this | ||
properly but in the worst case the tool will crash or perhaps have | ||
some missing output. That's far far better than crashing the host. | ||
|
||
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters