Skip to content

Commit

Permalink
Combine libraries: spl, avl, efi, share, unicode.
Browse files Browse the repository at this point in the history
These libraries, which are an artifact of the ZoL development
process, conflict with packages that are already in distribution:

  * libspl: SPL Programming Language
  * libavl: AVL for Linux
  * libefi: GRUB

And these libraries are potential conflicts:

  * libshare: the Linux Mount Manager
  * libunicode: Perl and Python

Recompose these five ZoL components into the four libraries that are
conventionally provided by Solaris and FreeBSD systems:

  + libnvpair
  + libuutil
  + libzpool
  + libzfs

This change resolves the name conflict, makes ZoL more compatible
with existing software that uses autotools to detect ZFS, and allows
pkg-zfs to better reflect the official Debian kFreeBSD packaging.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: #430
  • Loading branch information
dajhorn authored and behlendorf committed Jan 17, 2012
1 parent 57a4edd commit 7505628
Show file tree
Hide file tree
Showing 32 changed files with 154 additions and 485 deletions.
5 changes: 0 additions & 5 deletions cmd/mount_zfs/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ mount_zfs_SOURCES = \
$(top_srcdir)/cmd/mount_zfs/mount_zfs.c

mount_zfs_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzfs/libzfs.la

Expand Down
12 changes: 1 addition & 11 deletions cmd/mount_zfs/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,7 @@ am__installdirs = "$(DESTDIR)$(sbindir)"
PROGRAMS = $(sbin_PROGRAMS)
am_mount_zfs_OBJECTS = mount_zfs.$(OBJEXT)
mount_zfs_OBJECTS = $(am_mount_zfs_OBJECTS)
mount_zfs_DEPENDENCIES = $(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
mount_zfs_DEPENDENCIES = $(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzfs/libzfs.la
AM_V_lt = $(am__v_lt_$(V))
am__v_lt_ = $(am__v_lt_$(AM_DEFAULT_VERBOSITY))
Expand Down Expand Up @@ -333,11 +328,6 @@ mount_zfs_SOURCES = \
$(top_srcdir)/cmd/mount_zfs/mount_zfs.c

mount_zfs_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzfs/libzfs.la

Expand Down
4 changes: 0 additions & 4 deletions cmd/zdb/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ zdb_SOURCES = \
$(top_srcdir)/cmd/zdb/zdb_il.c

zdb_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
10 changes: 1 addition & 9 deletions cmd/zdb/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ am__installdirs = "$(DESTDIR)$(sbindir)"
PROGRAMS = $(sbin_PROGRAMS)
am_zdb_OBJECTS = zdb.$(OBJEXT) zdb_il.$(OBJEXT)
zdb_OBJECTS = $(am_zdb_OBJECTS)
zdb_DEPENDENCIES = $(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
zdb_DEPENDENCIES = $(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down Expand Up @@ -330,11 +326,7 @@ zdb_SOURCES = \
$(top_srcdir)/cmd/zdb/zdb_il.c

zdb_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
4 changes: 0 additions & 4 deletions cmd/zfs/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ zfs_SOURCES = \
$(top_srcdir)/cmd/zfs/zfs_util.h

zfs_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
10 changes: 1 addition & 9 deletions cmd/zfs/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ am__installdirs = "$(DESTDIR)$(sbindir)"
PROGRAMS = $(sbin_PROGRAMS)
am_zfs_OBJECTS = zfs_iter.$(OBJEXT) zfs_main.$(OBJEXT)
zfs_OBJECTS = $(am_zfs_OBJECTS)
zfs_DEPENDENCIES = $(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
zfs_DEPENDENCIES = $(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down Expand Up @@ -332,11 +328,7 @@ zfs_SOURCES = \
$(top_srcdir)/cmd/zfs/zfs_util.h

zfs_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
4 changes: 0 additions & 4 deletions cmd/zinject/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ zinject_SOURCES = \
$(top_srcdir)/cmd/zinject/zinject.h

zinject_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
10 changes: 1 addition & 9 deletions cmd/zinject/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ am__installdirs = "$(DESTDIR)$(sbindir)"
PROGRAMS = $(sbin_PROGRAMS)
am_zinject_OBJECTS = translate.$(OBJEXT) zinject.$(OBJEXT)
zinject_OBJECTS = $(am_zinject_OBJECTS)
zinject_DEPENDENCIES = $(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
zinject_DEPENDENCIES = $(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down Expand Up @@ -331,11 +327,7 @@ zinject_SOURCES = \
$(top_srcdir)/cmd/zinject/zinject.h

zinject_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
4 changes: 0 additions & 4 deletions cmd/zpool/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@ zpool_SOURCES = \
$(top_srcdir)/cmd/zpool/zpool_vdev.c

zpool_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
10 changes: 1 addition & 9 deletions cmd/zpool/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,7 @@ PROGRAMS = $(sbin_PROGRAMS)
am_zpool_OBJECTS = zpool_iter.$(OBJEXT) zpool_main.$(OBJEXT) \
zpool_util.$(OBJEXT) zpool_vdev.$(OBJEXT)
zpool_OBJECTS = $(am_zpool_OBJECTS)
zpool_DEPENDENCIES = $(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
zpool_DEPENDENCIES = $(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down Expand Up @@ -334,11 +330,7 @@ zpool_SOURCES = \
$(top_srcdir)/cmd/zpool/zpool_vdev.c

zpool_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
4 changes: 0 additions & 4 deletions cmd/ztest/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ ztest_SOURCES = \
$(top_srcdir)/cmd/ztest/ztest.c

ztest_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
10 changes: 1 addition & 9 deletions cmd/ztest/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ am__installdirs = "$(DESTDIR)$(sbindir)"
PROGRAMS = $(sbin_PROGRAMS)
am_ztest_OBJECTS = ztest.$(OBJEXT)
ztest_OBJECTS = $(am_ztest_OBJECTS)
ztest_DEPENDENCIES = $(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
ztest_DEPENDENCIES = $(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down Expand Up @@ -330,11 +326,7 @@ ztest_SOURCES = \
$(top_srcdir)/cmd/ztest/ztest.c

ztest_LDADD = \
$(top_builddir)/lib/libspl/libspl.la \
$(top_builddir)/lib/libavl/libavl.la \
$(top_builddir)/lib/libefi/libefi.la \
$(top_builddir)/lib/libnvpair/libnvpair.la \
$(top_builddir)/lib/libunicode/libunicode.la \
$(top_builddir)/lib/libuutil/libuutil.la \
$(top_builddir)/lib/libzpool/libzpool.la \
$(top_builddir)/lib/libzfs/libzfs.la
Expand Down
9 changes: 7 additions & 2 deletions lib/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
SUBDIRS = libspl libavl libefi libnvpair libshare
SUBDIRS += libunicode libuutil libzpool libzfs
# NB: GNU Automake Manual, Chapter 8.3.5: Libtool Convenience Libraries
# These five libraries are intermediary build components.
SUBDIRS = libspl libavl libefi libshare libunicode

# These four libraries, which are installed as the final build product,
# incorporate the five convenience libraries given above.
SUBDIRS += libnvpair libuutil libzpool libzfs
8 changes: 7 additions & 1 deletion lib/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,13 @@ top_builddir = @top_builddir@
top_srcdir = @top_srcdir@
udevdir = @udevdir@
udevruledir = @udevruledir@
SUBDIRS = libspl libavl libefi libnvpair libshare libunicode libuutil \

# NB: GNU Automake Manual, Chapter 8.3.5: Libtool Convenience Libraries
# These five libraries are intermediary build components.

# These four libraries, which are installed as the final build product,
# incorporate the five convenience libraries given above.
SUBDIRS = libspl libavl libefi libshare libunicode libnvpair libuutil \
libzpool libzfs
all: all-recursive

Expand Down
4 changes: 1 addition & 3 deletions lib/libavl/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ DEFAULT_INCLUDES += \
-I$(top_srcdir)/include \
-I$(top_srcdir)/lib/libspl/include

lib_LTLIBRARIES = libavl.la
noinst_LTLIBRARIES = libavl.la

libavl_la_SOURCES = \
$(top_srcdir)/module/avl/avl.c

libavl_la_LDFLAGS = -version-info 1:0:0
Loading

0 comments on commit 7505628

Please sign in to comment.