This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
fixed redefinition of PAGESIZE with musl libc #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll pull it in on Monday. |
|
@stef This header should never be compiled in user space against libc. It's just going to get built against the kernel headers. That said, wrapping this sort of thing in a |
ryao
pushed a commit
to ryao/spl
that referenced
this pull request
Nov 29, 2014
Add #ifndef PAGESIZE to avoid redefinition warning on platforms where this value is already provided. Signed-off-by: stf <s@ctrlc.hu> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#382
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility with musl which does define PAGESIZE to PAGE_SIZE already.