This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Return -1 for generic kmem cache shrinker #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been observed that it's possible to get in a state where shrink_slabs() will spin repeated invoking the generic kmem cache shrinker. It fails to detect it's not making forward progress reclaiming from the cache and doesn't give up. To ensure this never occurs we unconditionally return -1 after reclaiming what we can. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs/zfs#1276 Issue openzfs/zfs#1598
|
Also expected to fix openzfs/zfs#1432 |
|
The same change should probably be made to the arc_shrinker. I will refresh openzfs/zfs#1613 to include it. |
|
@ryao You know I've never seen or had reports of similar spinning in arc_shrinker(), it may have something to do with the fact that the generic spl shrinker is for multiple caches. |
|
b9b3715 Return -1 for generic kmem cache shrinker |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that it's possible to get in a state where
shrink_slabs() will spin repeated invoking the generic kmem cache
shrinker. It fails to detect it's not making forward progress
reclaiming from the cache and doesn't give up. To ensure this
never occurs we unconditionally return -1 after reclaiming what
we can.
Signed-off-by: Brian Behlendorf behlendorf1@llnl.gov
Issue openzfs/zfs#1276
Issue openzfs/zfs#1598