Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added note on how to fix issue #349 #350

Closed
wants to merge 1 commit into from

Conversation

alb-i
Copy link

@alb-i alb-i commented Sep 17, 2022

Added description on how to fix the issue #349.

@rlaager
Copy link
Member

rlaager commented Sep 19, 2022

I thought -d was supposed to take a directory, not the device itself. Can you provide more information on what your disk setup is like?

@rlaager rlaager self-assigned this Sep 19, 2022
@alb-i
Copy link
Author

alb-i commented Sep 20, 2022

A quick look at man zpool-import tells us, that

             -d dir|device
                     Uses device or searches for devices or files in dir.  The -d option can be specified multiple times.

My disk setup:

lrwxrwxrwx 1 root root 13 Sep 20 07:52 nvme-Samsung_SSD_970_EVO_Plus_2TB_S4J4NJ0N700800Y -> ../../nvme1n1
lrwxrwxrwx 1 root root 15 Sep 20 07:52 nvme-Samsung_SSD_970_EVO_Plus_2TB_S4J4NJ0N700800Y-part1 -> ../../nvme1n1p1
lrwxrwxrwx 1 root root 13 Sep 20 07:52 nvme-Samsung_SSD_970_EVO_Plus_2TB_S4J4NJ0N700808B -> ../../nvme0n1
lrwxrwxrwx 1 root root 15 Sep 20 07:52 nvme-Samsung_SSD_970_EVO_Plus_2TB_S4J4NJ0N700808B-part2 -> ../../nvme0n1p2
lrwxrwxrwx 1 root root 15 Sep 20 07:52 nvme-Samsung_SSD_970_EVO_Plus_2TB_S4J4NJ0N700808B-part3 -> ../../nvme0n1p3
lrwxrwxrwx 1 root root 15 Sep 20 07:52 nvme-Samsung_SSD_970_EVO_Plus_2TB_S4J4NJ0N700808B-part4 -> ../../nvme0n1p4

where nvme0 is setup as in the text, nvme1 only has one zfs-partition that has been added to extend the rpool.

@alb-i
Copy link
Author

alb-i commented Sep 28, 2022

so, any updates regarding the PR? I'm going to close it due to inactivity soon.

@alb-i alb-i closed this Oct 1, 2022
@rlaager
Copy link
Member

rlaager commented Oct 1, 2022

Merged with changes as 81b6c20

@rlaager
Copy link
Member

rlaager commented Oct 1, 2022

I missed your follow-up. Thanks for the suggestion. I wish I knew more about what was going on, but adding the note seems reasonable for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants