Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【FIX】Update service topology for k8s 1.21 and unit test #834

Merged
merged 2 commits into from
May 27, 2022

Conversation

JameKeal
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

The service takes effect in the new version

Which issue(s) this PR fixes:

https://github.com/openyurtio/openyurt/issues/789

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

The service takes effect in the new version

Which issue(s) this PR fixes:

https://github.com/openyurtio/openyurt/issues/789

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

@JameKeal Adapt service topology for K8s v1.21.x, but k8s libraries version in go.mod are updated to v1.22.3, I think if we update go.mod in this pull request, maybe other features could not work.

@JameKeal
Copy link
Member Author

@JameKeal Adapt service topology for K8s v1.21.x, but k8s libraries version in go.mod are updated to v1.22.3, I think if we update go.mod in this pull request, maybe other features could not work.

By your means, if I don't update go.mod, someone who pull the master branch to build code, it's also fail.

If you think it's not a problem, I can recover the go.mod.

@Congrool
Copy link
Member

Congrool commented May 16, 2022

Adapt service topology for K8s v1.21.x, but k8s libraries version in go.mod are updated to v1.22.3, I think if we update go.mod in this pull request, maybe other features could not work.

I think we can merge #821 before this pr, at that time, everything will be ok.

@rambohe-ch
Copy link
Member

Fixes #789

@rambohe-ch
Copy link
Member

@JameKeal please rebase the newest master branch.

@rambohe-ch rambohe-ch linked an issue May 25, 2022 that may be closed by this pull request
@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 and removed size/XXL labels May 26, 2022
@openyurt-bot openyurt-bot added the approved approved label May 26, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit f844192 into openyurtio:master May 27, 2022
@JameKeal JameKeal deleted the 20220514-pr branch February 14, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ServiceTopology does not take effect in k8s 1.21 version
4 participants