-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【FIX】Update service topology for k8s 1.21 and unit test #834
Conversation
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JameKeal Adapt service topology for K8s v1.21.x, but k8s libraries version in go.mod are updated to v1.22.3, I think if we update go.mod in this pull request, maybe other features could not work. |
By your means, if I don't update go.mod, someone who pull the master branch to build code, it's also fail. If you think it's not a problem, I can recover the go.mod. |
I think we can merge #821 before this pr, at that time, everything will be ok. |
Fixes #789 |
@JameKeal please rebase the newest master branch. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
The service takes effect in the new version
Which issue(s) this PR fixes:
https://github.com/openyurtio/openyurt/issues/789
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note