-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove k8s.io/kubernetes dependency for yurtctl #681
Conversation
Welcome @Rachel-Shao! It looks like this is your first PR to openyurtio/openyurt 🎉 |
@Rachel-Shao Very appreciate for your pull request, agree with you that eliminate dependency on k8s.io/kubernetes. please fix the comments and golang lint error. |
6877002
to
ead4810
Compare
@Rachel-Shao please fix go vet error. |
2896841
to
db0cc35
Compare
@Rachel-Shao we should do not import k8s.io/klog, and please use k8s.io/klog/v2 instead. |
@rambohe-ch I actually use |
@Rachel-Shao maybe you can execute |
Signed-off-by: Rachel-Shao <34911960+Rachel-Shao@users.noreply.github.com>
6d0f14b
to
32fd3f3
Compare
@rambohe-ch done! plz approve running workflows:) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rachel-Shao, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rachel-Shao <34911960+Rachel-Shao@users.noreply.github.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Relying directly on
k8s.io/kubernetes
didn't seem like a good idea, which made our project difficult to upgrade and maintain. It's better that eliminate dependency onk8s.io/kubernetes
.Which issue(s) this PR fixes:
Fixes #550
Special notes for your reviewer:
I did not change the relevant code in
yurt join/init/reset
, because it involves a huge amount...For other parts, I unified the relevant functions inpkg/util/kubeadmapi/kubeadmapi.go
Does this PR introduce a user-facing change?
none