[WIP] yurtcl join use node-servant #630
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adamzhoul The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cf515a2 to
e99ebb2
Compare
e99ebb2 to
44d5da4
Compare
| return err | ||
| } | ||
| } | ||
|
|
||
| if err := apiclient.PatchNode(client, cfg.NodeRegistration.Name, func(n *v1.Node) { | ||
| n.Labels[projectinfo.GetEdgeWorkerLabelKey()] = "true" |
There was a problem hiding this comment.
how about move makeAutonomous at here?
There was a problem hiding this comment.
Do you mean using MarkAutonomousOptions int pkg/yurtctl/cmd/markautonomous/markautonomous.go
co := NewMarkAutonomousOptions()
o.RunMarkAutonomous()
it's definitely better using this.
But, it has serval questions we have to answer:
- a
kubeconffile is required, and we may usekubelet.conf. Is this ok? - join package import markautonomous package is ok but not advised I think.
There was a problem hiding this comment.
@adamzhoul I'm sorry that the comment is not clear. i mean that move the code line 114~120 after line 122, so reduce one node patch request.
|
don't have enough time to have a full test. so close this pr for now. |
What type of PR is this?
Which issue(s) this PR fixes:
#597 [feature request] Add an option to "yurtctl join" to enable "node autonomy" automatically.
#545 [feature request] yurtctl join use node-servant to finish some job
#516 add node-servant