Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: establish the component mechanism of the iot system #1650

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

LavenderQAQ
Copy link
Member

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

Build PlatformAdmin's component mechanism to allow users to deploy common edgex extensions by simply filling in the component name.

Which issue(s) this PR fixes:

Fixes #1611

@openyurt-bot openyurt-bot added do-not-merge/work-in-progress do-not-merge/work-in-progress kind/feature kind/feature labels Aug 12, 2023
@openyurt-bot openyurt-bot added sig/iot sig/iot size/L size/L: 100-499 labels Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #1650 (07c4661) into master (d15078f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1650   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files         154      154           
  Lines       17637    17637           
=======================================
  Hits         9228     9228           
  Misses       7582     7582           
  Partials      827      827           
Flag Coverage Δ
unittests 52.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@LavenderQAQ LavenderQAQ marked this pull request as ready for review August 13, 2023 07:31
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Aug 13, 2023
@LavenderQAQ
Copy link
Member Author

This pr is done, but it needs to wait for #1647 to merge.

@LavenderQAQ
Copy link
Member Author

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Aug 13, 2023
@LavenderQAQ
Copy link
Member Author

LavenderQAQ commented Aug 13, 2023

@wangxye @Rui-Gan Please review it for me. This pr currently includes the content of #1647 (because it has not been merged but I need its content), I will rebase it later, please ignore it when reviewing now.

@LavenderQAQ
Copy link
Member Author

/assign @wangxye @Rui-Gan

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: GitHub didn't allow me to assign the following users: wangxye, Rui-Gan.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wangxye @Rui-Gan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LavenderQAQ LavenderQAQ force-pushed the feat/component-mechanism branch 3 times, most recently from 0dabcbd to ab084e8 Compare August 14, 2023 02:37
@LavenderQAQ
Copy link
Member Author

/unhold

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label Aug 14, 2023
@LavenderQAQ
Copy link
Member Author

LavenderQAQ commented Aug 14, 2023

This pr is ready for review.

@LavenderQAQ LavenderQAQ force-pushed the feat/component-mechanism branch from ab084e8 to a42b230 Compare August 14, 2023 02:46
@Rui-Gan
Copy link
Member

Rui-Gan commented Aug 16, 2023

/assign

@Rui-Gan
Copy link
Member

Rui-Gan commented Aug 17, 2023

/lgtm

@openyurt-bot
Copy link
Collaborator

@Rui-Gan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the approved approved label Aug 17, 2023
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
@LavenderQAQ LavenderQAQ force-pushed the feat/component-mechanism branch from 77b193e to 07c4661 Compare August 21, 2023 03:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm sig/iot sig/iot size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Establish the component mechanism of the iot system
4 participants