Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move controller register into controller.go #1397

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

xavier-hou
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1393

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Signed-off-by: hxcGit <houxc_mail@163.com>
@openyurt-bot
Copy link
Collaborator

@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1393

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Apr 20, 2023
Signed-off-by: hxcGit <houxc_mail@163.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1397 (27cb35b) into master (cb29dc3) will decrease coverage by 0.77%.
The diff coverage is 34.91%.

@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage   51.83%   51.06%   -0.77%     
==========================================
  Files         125      132       +7     
  Lines       14832    15548     +716     
==========================================
+ Hits         7688     7940     +252     
- Misses       6449     6884     +435     
- Partials      695      724      +29     
Flag Coverage Δ
unittests 51.06% <34.91%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/yurtappdaemon/revision.go 17.70% <17.70%> (ø)
...ntroller/yurtappdaemon/yurtappdaemon_controller.go 19.60% <19.60%> (ø)
...daemon/workloadcontroller/deployment_controller.go 64.92% <64.92%> (ø)
...troller/yurtappdaemon/nodepool_enqueue_handlers.go 70.00% <70.00%> (ø)
pkg/controller/yurtappdaemon/util.go 73.68% <73.68%> (ø)
...ontroller/yurtappdaemon/workloadcontroller/util.go 85.71% <85.71%> (ø)
...oller/yurtappdaemon/workloadcontroller/workload.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]combine all all_xxx.go files in pkg/controller into controller.go file.
3 participants