-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move controller register into controller.go #1397
Conversation
Signed-off-by: hxcGit <houxc_mail@163.com>
@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: hxcGit <houxc_mail@163.com>
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1397 +/- ##
==========================================
- Coverage 51.83% 51.06% -0.77%
==========================================
Files 125 132 +7
Lines 14832 15548 +716
==========================================
+ Hits 7688 7940 +252
- Misses 6449 6884 +435
- Partials 695 724 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, xavier-hou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1393
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note