-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support to specify enabled controllers #1388
Conversation
Signed-off-by: hxcGit <houxc_mail@163.com>
@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
- Coverage 51.88% 51.84% -0.05%
==========================================
Files 124 125 +1
Lines 14820 14832 +12
==========================================
Hits 7689 7689
- Misses 6437 6449 +12
Partials 694 694
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@xavier-hou some webhooks maybe have not connected controllers, so we need to add a parameter |
Signed-off-by: hxcGit <houxc_mail@163.com>
So I think current PR is enough for enabling and disabling controllers. But If we just want to enable or disable webhooks, then we can add a new parameter |
@rambohe-ch We have lots of files aimed at adding controllers to |
@xavier-hou I agree your idea to combine these controller files into one file, and i'd like to create a new issue to track this case. |
@xavier-hou and i will merge this pr at first. |
Signed-off-by: hxcGit <houxc_mail@163.com>
Kudos, SonarCloud Quality Gate passed!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, xavier-hou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1379
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note