Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add luckymrwang as maintainer of OpenYurt #1376

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

luckymrwang
Copy link
Member

@luckymrwang luckymrwang commented Apr 17, 2023

GitHub Username

@luckymrwang

Organization you are requesting membership in

@openyurt

Sponsors

@rambohe-ch

Requirements

  • I have joined in the community Dingding and [WeChat]
  • I often attend Openyurt Community Week
  • I have reviewed the [community membership docs]
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
  • I have checked my affiliation in devstats (if it's not correct, please fix in cncf/gitdm)
  • I am actively contributing to 1 or more OpenYurt subprojects

List of your major contributions

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1376 (d34af1f) into master (9d3eeba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1376   +/-   ##
=======================================
  Coverage   51.48%   51.48%           
=======================================
  Files         125      125           
  Lines       15021    15021           
=======================================
  Hits         7733     7733           
  Misses       6589     6589           
  Partials      699      699           
Flag Coverage Δ
unittests 51.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@luckymrwang Thank you for contributing OpenYurt for more than one year, and i am glad to agree with you to be Maintainer of OpenYurt.

@gnunu
Copy link
Member

gnunu commented Apr 19, 2023

/LGTM

@openyurt-bot
Copy link
Collaborator

@gnunu: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luckymrwang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Apr 20, 2023
@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants