Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yurtadm renew certificate command #1314

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Mar 17, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. add yurtadm renew certificate command
  2. gather the yurthub-related functions into pkg/yurtadm/util/yurthub/yurthub.go
  3. gather CheckKubeletStatus function into pkg/yurtadm/util/kubernetes/kubernetes.go
  4. When building a test cluster, yurthub is also started with a bootstrap file

Which issue(s) this PR fixes:

Fixes #1290

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Mar 17, 2023
@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Mar 17, 2023
@YTGhost YTGhost changed the title feat: improve bootstrap configuration for YurtHub [WIP] feat: improve bootstrap configuration for YurtHub Mar 17, 2023
@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1314 (6333e35) into master (6c3cb34) will decrease coverage by 0.10%.
The diff coverage is 40.47%.

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
- Coverage   53.10%   53.01%   -0.10%     
==========================================
  Files         102      103       +1     
  Lines       12833    12891      +58     
==========================================
+ Hits         6815     6834      +19     
- Misses       5461     5499      +38     
- Partials      557      558       +1     
Flag Coverage Δ
unittests 53.01% <40.47%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurtadm/util/error/error.go 40.47% <40.47%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YTGhost YTGhost force-pushed the bootstrap-yurthub branch 2 times, most recently from 61a1294 to 75e7b85 Compare March 27, 2023 15:59
@YTGhost YTGhost changed the title [WIP] feat: improve bootstrap configuration for YurtHub feat: add yurtadm renew certificate command Mar 27, 2023
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Mar 27, 2023
@YTGhost YTGhost force-pushed the bootstrap-yurthub branch from 75e7b85 to dd63e30 Compare March 27, 2023 16:04
@YTGhost
Copy link
Member Author

YTGhost commented Mar 27, 2023

@rambohe-ch PTAL

@YTGhost YTGhost force-pushed the bootstrap-yurthub branch 2 times, most recently from 95466c0 to 4ea85f1 Compare March 27, 2023 16:15
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Mar 28, 2023
@rambohe-ch
Copy link
Member

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Mar 28, 2023
@rambohe-ch
Copy link
Member

@YTGhost this pull request depends on the #1333 , we need to rebase after #1333 merge.

@YTGhost YTGhost force-pushed the bootstrap-yurthub branch 5 times, most recently from dad3099 to ea9c111 Compare March 28, 2023 07:56
@YTGhost YTGhost force-pushed the bootstrap-yurthub branch 4 times, most recently from 74ee29f to e96f74b Compare March 29, 2023 08:28
Signed-off-by: Liang Deng <283304489@qq.com>
@YTGhost YTGhost force-pushed the bootstrap-yurthub branch from e96f74b to 6333e35 Compare March 29, 2023 10:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@YTGhost
Copy link
Member Author

YTGhost commented Mar 29, 2023

@rambohe-ch PTAL

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/unhold

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label Mar 29, 2023
@rambohe-ch
Copy link
Member

/hold cancel

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Mar 29, 2023
@openyurt-bot openyurt-bot merged commit 08bd281 into openyurtio:master Mar 29, 2023
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request Apr 4, 2023
Signed-off-by: Liang Deng <283304489@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve bootstrap configuration for YurtHub
3 participants