-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add PoolScopeResource validation and dynamic configuration support #1148
Merged
rambohe-ch
merged 8 commits into
openyurtio:pool-coordinator-dev
from
LaurenceLiZhixin:fix-pool-scope-verify
Jan 17, 2023
Merged
Fix: add PoolScopeResource validation and dynamic configuration support #1148
rambohe-ch
merged 8 commits into
openyurtio:pool-coordinator-dev
from
LaurenceLiZhixin:fix-pool-scope-verify
Jan 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambohe-ch
reviewed
Jan 15, 2023
rambohe-ch
reviewed
Jan 15, 2023
rambohe-ch
approved these changes
Jan 17, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaurenceLiZhixin, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
Congrool
pushed a commit
to Congrool/openyurt
that referenced
this pull request
Jan 18, 2023
…rt (openyurtio#1148) * Fix: add PoolScopeResource validation and dynamic configuration support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add PoolScopeResource validation to support multi version of pool scope resources, like v1/v1beta1 version of endpointslices.
Add pool scope resource type configuration, which read from yurt-hub-cfg cm's
pool_scope_resources
key.For example:
we can add
into yurt-hub-cfg config map to let pool-coordinator cache pods resources.