Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add PoolScopeResource validation and dynamic configuration support #1148

Conversation

LaurenceLiZhixin
Copy link
Member

@LaurenceLiZhixin LaurenceLiZhixin commented Jan 14, 2023

  1. add PoolScopeResource validation to support multi version of pool scope resources, like v1/v1beta1 version of endpointslices.

  2. Add pool scope resource type configuration, which read from yurt-hub-cfg cm's pool_scope_resources key.
    For example:
    we can add

 pool_scope_resources: '[{"Group":"","Version":"v1","Resource":"pods"}]'

into yurt-hub-cfg config map to let pool-coordinator cache pods resources.

  1. Add etcd transaction max num to 100k.
  2. Add dynamic client for pool-coordinator to support crd informer.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jan 14, 2023
@LaurenceLiZhixin LaurenceLiZhixin changed the title Fix: add PoolScopeResource validation and dynamic configuration support [WIP] Fix: add PoolScopeResource validation and dynamic configuration support Jan 14, 2023
@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Jan 14, 2023
@LaurenceLiZhixin LaurenceLiZhixin changed the title [WIP] Fix: add PoolScopeResource validation and dynamic configuration support Fix: add PoolScopeResource validation and dynamic configuration support Jan 14, 2023
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Jan 14, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaurenceLiZhixin, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jan 17, 2023
@rambohe-ch rambohe-ch merged commit 803e233 into openyurtio:pool-coordinator-dev Jan 17, 2023
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Jan 18, 2023
…rt (openyurtio#1148)

* Fix: add PoolScopeResource validation and dynamic configuration support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants