Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coordinator sync problem and update ready condition #1142

Merged

Conversation

Congrool
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. make updating coordinator fields as atomic operation
  2. add isPoolCacheSynced as one condition of pool-coordinator ready, fix what we didn't do in bufix: set isPoolCacheSynced as true if lease updated #1131

As discussed in #1126 (comment):

We should make the update of coordinator as an atomic operation to avoid undefined situation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Signed-off-by: Congrool <chpzhangyifei@zju.edu.cn>
Signed-off-by: Congrool <chpzhangyifei@zju.edu.cn>
@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. make updating coordinator fields as atomic operation
  2. add isPoolCacheSynced as one condition of pool-coordinator ready, fix what we didn't do in bufix: set isPoolCacheSynced as true if lease updated #1131

As discussed in #1126 (comment):

We should make the update of coordinator as an atomic operation to avoid undefined situation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Jan 12, 2023
@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (pool-coordinator-dev@81aa62b). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             pool-coordinator-dev    #1142   +/-   ##
=======================================================
  Coverage                        ?   47.84%           
=======================================================
  Files                           ?      109           
  Lines                           ?    13695           
  Branches                        ?        0           
=======================================================
  Hits                            ?     6552           
  Misses                          ?     6582           
  Partials                        ?      561           
Flag Coverage Δ
unittests 47.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jan 12, 2023
@rambohe-ch rambohe-ch merged commit 094a273 into openyurtio:pool-coordinator-dev Jan 12, 2023
@Congrool Congrool deleted the coordinator-sync-fix branch January 12, 2023 12:54
Congrool added a commit to Congrool/openyurt that referenced this pull request Jan 17, 2023
)

* make coordinator fields update atomic

Signed-off-by: Congrool <chpzhangyifei@zju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants