Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor yurtadm reset #1075

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 25, 2022

Signed-off-by: HIHIA 283304489@qq.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

yurtadm join command is optimized based on the kubeadm join command, it's natural that optimize yurtadm reset command in the same way.

Which issue(s) this PR fixes:

Fixes #1058

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Signed-off-by: HIHIA <283304489@qq.com>
@YTGhost YTGhost force-pushed the optimize-yurtadm-reset branch from e9c0467 to f8d76e1 Compare November 25, 2022 04:50
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1075 (f8d76e1) into master (08aa8e3) will increase coverage by 1.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   51.60%   52.85%   +1.25%     
==========================================
  Files         101       91      -10     
  Lines       13552    12380    -1172     
==========================================
- Hits         6993     6544     -449     
+ Misses       5971     5270     -701     
+ Partials      588      566      -22     
Flag Coverage Δ
unittests 52.85% <ø> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bernetes/kubeadm/app/util/apiclient/idempotency.go
...util/kubernetes/kubeadm/app/util/apiclient/wait.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Nov 25, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 1fbb2f8 into openyurtio:master Nov 25, 2022
@YTGhost YTGhost mentioned this pull request Feb 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]optimize yurtadm reset command
3 participants